From 4a08067caf2fb2200a6c2106249a61d023dcf05d Mon Sep 17 00:00:00 2001 From: Isuru Fernando Date: Sun, 26 Apr 2020 16:04:26 +0000 Subject: [PATCH] Avoid opening the file twice --- setup.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/setup.py b/setup.py index db6a24e..94e1d02 100644 --- a/setup.py +++ b/setup.py @@ -40,18 +40,18 @@ def has_flag(compiler, flagname): """ import tempfile import os - with tempfile.NamedTemporaryFile('w', suffix='.cpp') as f: + with tempfile.NamedTemporaryFile('w', suffix='.cpp', delete=False) as f: f.write('int main (int argc, char **argv) { return 0; }') fname = f.name + try: + compiler.compile([fname], extra_postargs=[flagname]) + except setuptools.distutils.errors.CompileError: + return False + finally: try: - compiler.compile([fname], extra_postargs=[flagname]) - except setuptools.distutils.errors.CompileError: - return False - finally: - try: - os.remove(fname) - except OSError: - pass + os.remove(fname) + except OSError: + pass return True